Add favorite note to profiles #205

peddling638 · 2026-07-06T21:10:53+02:00

peddling638 commented

2026-07-06 21:10:53 +02:00

First-time contributor

Resolves #137

Resolves https://git.opengrind.org/open-grind/open-grind/issues/137

peddling638 commented

2026-07-07 11:51:23 +02:00

First-time contributor

Edit modal for the note and phone number

Note truncates if it is too long

When you only have the profile as favorite you will see the icon on top right - this is empty note.

![CleanShot 2026-07-07 at 11.50.59](/attachments/18040146-dac3-437e-bc29-9afee1f59584) Edit modal for the note and phone number ![CleanShot 2026-07-07 at 11.50.41](/attachments/7240e96c-d68e-424f-bf0f-dd26e32a5201) Note truncates if it is too long ![CleanShot 2026-07-07 at 11.50.26](/attachments/112fa618-b766-4757-9629-9e738a50008b) When you only have the profile as favorite you will see the icon on top right - this is empty note.

CleanShot 2026-07-07 at 11.50.59.png

183 KiB

CleanShot 2026-07-07 at 11.50.26.png

143 KiB

CleanShot 2026-07-07 at 11.50.41.png

145 KiB

peddling638 requested review from hloth

2026-07-08 13:45:18 +02:00

hloth commented

2026-07-09 16:51:24 +02:00

I'm thinking of a better design that would fit Open Grind, look around https://www.shadcn-svelte.com/docs/components maybe you'll think of something that's both convinient on mobiles and compact on desktops.

peddling638 commented

2026-07-10 13:04:55 +02:00

First-time contributor

Drawer version

![CleanShot 2026-07-10 at 13.04.45@2x](/attachments/32357a7f-77f5-4609-b7e1-e718b34a2a4c) Drawer version

CleanShot 2026-07-10 at 13.04.45@2x.png

548 KiB

hloth requested changes

2026-07-10 17:39:21 +02:00

hloth left a comment

Also in compliance with https://git.opengrind.org/open-grind/open-grind/src/branch/main/CONTRIBUTING.md#submitting-your-changes requiremenets, please configure your git to commit with the email activated in your account and enable commit signing using a key added & verified in your git.opengrind.org account

src/routes/(protected)/(navbar)/profile/[profileId]/ProfileNote.svelte Outdated

					
				@ -0,0 +19,4 @@

					}: { profile: Profile | null; note: FavoriteNote | null } = $props();

					const NOTE_MAX_LENGTH = 250;

					const PHONE_MAX_LENGTH = 32;

Where do 250 and 32 come from?

Where do `250` and `32` come from?

Actually found out that the phone length is max 20 characters and note max length is visible in the official Grindr app.

peddling638 marked this conversation as resolved

src/routes/(protected)/(navbar)/profile/[profileId]/ProfileNote.svelte Outdated

					
				@ -0,0 +73,4 @@

							class="w-full min-w-0 cursor-pointer text-base"

							onclick={() => (open = true)}

						>

							<NoteIcon class="size-4 shrink-0" />

Let's replace this icon with filled note-pencil icon, this way it can act as both "a note" icon and "edit me" action button.

peddling638 marked this conversation as resolved

hloth added this to the v0.1.0-beta.4 milestone

2026-07-11 21:18:20 +02:00

peddling638 force-pushed feat/137-add-notes-to-favorite-profiles from f332c3a080 to dd243b78fe

2026-07-12 00:52:21 +02:00

Compare

peddling638 added 2 commits

2026-07-12 00:57:38 +02:00

Changed favorite note icon 9692d3fd28

Changed max phone note length 1b68201c00

peddling638 added 1 commit

2026-07-12 00:58:11 +02:00

Merge branch 'main' into feat/137-add-notes-to-favorite-profiles ff39e8f6e5

hloth commented

2026-07-12 16:27:58 +02:00

Don't forget to add & verify your signing key here — https://git.opengrind.org/user/settings/keys
Otherwise your commits show up as "No known key found for this signature in database"

Don't forget to add & verify your signing key here — https://git.opengrind.org/user/settings/keys Otherwise your commits show up as "No known key found for this signature in database"

peddling638 force-pushed feat/137-add-notes-to-favorite-profiles from ff39e8f6e5 to 0550507d5a

2026-07-13 11:13:00 +02:00

Compare

peddling638 commented

2026-07-13 11:13:24 +02:00

First-time contributor

@hloth wrote in #205 (comment):

Don't forget to add & verify your signing key here — https://git.opengrind.org/user/settings/keys Otherwise your commits show up as "No known key found for this signature in database"

fixed =)

@hloth wrote in https://git.opengrind.org/open-grind/open-grind/pulls/205#issuecomment-1725: > Don't forget to add & verify your signing key here — https://git.opengrind.org/user/settings/keys Otherwise your commits show up as "No known key found for this signature in database" fixed =)

peddling638 added 1 commit

2026-07-16 13:15:59 +02:00

Merge branch 'main' into feat/137-add-notes-to-favorite-profiles c708c28001

peddling638 requested review from hloth

2026-07-16 13:16:02 +02:00

hloth referenced this pull request

2026-07-21 02:22:45 +02:00

feat: add profile interaction api helpers #69

This pull request has changes conflicting with the target branch.

src/lib/api/users/favorites.ts
src/routes/(protected)/(navbar)/profile/[profileId]/+page.svelte
src/routes/(protected)/(navbar)/profile/[profileId]/ImageCarousel.svelte
src/routes/(protected)/(navbar)/profile/[profileId]/top-nav/FavoriteProfileToggle.svelte
src/routes/(protected)/(navbar)/profile/[profileId]/top-nav/ProfileTopNavBar.svelte

View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Merge commit title

Merge pull request 'Add favorite note to profiles' (#205) from peddling638/open-grind:feat/137-add-notes-to-favorite-profiles into main

Merge commit body

Reviewed-on: https://git.opengrind.org/open-grind/open-grind/pulls/205

Merge pull request 'Add favorite note to profiles' (#205) from peddling638/open-grind:feat/137-add-notes-to-favorite-profiles into main

Reviewed-on: https://git.opengrind.org/open-grind/open-grind/pulls/205