Feat(Albums): Overhauled Album Viewer #216

Closed
TheFantasticLoki wants to merge 1 commit from TheFantasticLoki/open-grind:albumMessage-refactor into main
Contributor

Summary

Overhauled Album Viewer to support new features and improve visuals.

Features

New interactive footer featuring an interactive profile display with avatar, album name display with profile distance fallback, New slide counter cluster featuring animated pill style display above a digital read out, new action wheel for tapping, replying to or reporting album media and a dedicated message compose form for reply composition whilst viewing target media.

What's left?

Reports still need API documentation preventing report form modal and supporting backed API submission function creation. Therefore report action is wired to an unimplemented toast until said tasks are complete. Unit and Integration tests need to be made as well for this. Content types for album content reactions and replies are not implemented either as they are outside the scope of these changes.

Showcase Video

# Summary Overhauled Album Viewer to support new features and improve visuals. ## Features New interactive footer featuring an interactive profile display with avatar, album name display with profile distance fallback, New slide counter cluster featuring animated pill style display above a digital read out, new action wheel for tapping, replying to or reporting album media and a dedicated message compose form for reply composition whilst viewing target media. ## What's left? Reports still need API documentation preventing report form modal and supporting backed API submission function creation. Therefore report action is wired to an unimplemented toast until said tasks are complete. Unit and Integration tests need to be made as well for this. Content types for album content reactions and replies are not implemented either as they are outside the scope of these changes. ## Showcase Video
# Summary

Overhauled Album Viewer to support new features and improve visuals.

## Features

New interactive footer featuring a profile display with avatar, album name display with profile distance fallback, New slide counter cluster featuring animated pill style display above a digital read out, new action wheel for tapping, replying to or reporting album media and a dedicated message compose form for reply composition whilst viewing target media.

## What's left?

Reports still need api documentation preventing report form modal and supporting backend api submission function creation. Therefore report action is wired to an unimplemented toast until said tasks are complete. Unit and Integration tests need to be made as well for this. Content types for album content reactions and replies are not implemented either as they are outside the scope of these changes.
TheFantasticLoki force-pushed albumMessage-refactor from a10ab6fcfd to 2899f3ecaa 2026-07-09 14:48:36 +02:00 Compare
TheFantasticLoki force-pushed albumMessage-refactor from 2899f3ecaa to 884017ae72 2026-07-09 15:01:45 +02:00 Compare
TheFantasticLoki requested reviews from hloth and removed review requests for Owners 2026-07-09 16:13:59 +02:00
Owner

Hi, I'm going to close this now, because I don't believe it earns its place in the project. There are several new features your PR adds:

  1. Album sender profile β€” albums are currently only accessible via 1-to-1 chats, so a profile bar seems redundant; when #281 eventually lands this will be a part of the feature's UI
  2. Album name with distance fallback β€” album names are private to author, and free accounts are limited to 1 album anyway, so albums shared by others will always print distance fallback (which seems out of place to me), and your own albums would print a name you don't really even need to read (because the majority of users will have a single album)
  3. Slider pills β€” this would be a great addition, but it probably has to be done for everywhere the lightbox slideshow is rendered
  4. Album reactions wheel β€” albums can only have one reaction (the official app renders it as "πŸ”₯"), the reaction wheel design does not fit Open Grind design
  5. Reply message composer β€” superseded by !512

Albums reports are tracked via #215, in case you want to contribute it via a separate PR.

Thank you.

Hi, I'm going to close this now, because I don't believe it earns its place in the project. There are several new features your PR adds: 1. Album sender profile β€” albums are currently only accessible via 1-to-1 chats, so a profile bar seems redundant; when #281 eventually lands this will be a part of the feature's UI 2. Album name with distance fallback β€” album names are private to author, and free accounts are limited to 1 album anyway, so albums shared by others will always print distance fallback (which seems out of place to me), and your own albums would print a name you don't really even need to read (because the majority of users will have a single album) 3. Slider pills β€” this would be a great addition, but it probably has to be done for everywhere the lightbox slideshow is rendered 4. Album reactions wheel β€” albums can only have one reaction (the official app renders it as "πŸ”₯"), the reaction wheel design does not fit Open Grind design 5. Reply message composer β€” superseded by !512 Albums reports are tracked via #215, in case you want to contribute it via a separate PR. Thank you.
hloth closed this pull request 2026-11-01 20:51:47 +01:00

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
open-grind/open-grind!216
No description provided.