(feat #43) Right now feed - Phase 1 #328
No reviewers
Labels
No labels
app
app
bug
app
enhancement
client side exclusive
closed
completed
closed
duplicate
closed
invalid
closed
not open grind
closed
not planned
closed
question
🗳️ community vote
⚠️ critical
discussion
docs
emulator
help wanted
paywalled
bypassable
paywalled
non-bypassable
paywalled
unconfirmed
pr/dubious
question
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
open-grind/open-grind!328
Loading…
Reference in a new issue
No description provided.
Delete branch "KinkyMonk/open-grind:newrightnow"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Most of the work was done in #236, but since it's been quite a while since I opened that PR and I didn't want to go through merge hell, I started from clean slate and ported the files ones by one.
Supported
Not implemented in this PR
AgeQuickFilterusesdismissOnBackGesture(as do 11 other files) andDrawer.Body; the other three drawers usebackGestureEventHandlers.add/deleteand use a bare<div>accountPreferenceKeysshould haverightNowFiltersjust likegridSearchFilters)AGE_MIN/AGE_MAXinstead of hardcoded[18, 102]resetFilters()double-savesimediaOftypoz.number().int()instead ofz.int()text-gray-400when the codebase usestext-muted-foregroundmediaStates+$effectinRightNowPost@ -0,0 +67,4 @@});export type LockedPostV1 = z.infer<typeof LockedPostV1Schema>;export const RightNowFeedResponseItemSchema = z.discriminatedUnion("type", [New spec says "Unrecognized type values are tolerated by the client". We now have src/lib/model/tolerance.ts with arrayOfKnownVariants. Use it instead of strict z.discriminatedUnion.
@ -0,0 +10,4 @@class RightNowState {filters = new RightNowSearchFiltersState({onQueryChange: () => {console.log(11);Delete
@ -0,0 +11,4 @@filters = new RightNowSearchFiltersState({onQueryChange: () => {console.log(11);this.refresh();Network request after sign-out. The grid's
reset()assignsthis.valuedirectly to avoid this, and grid-state.svelte.test.ts:375 asserts it.In the grid, tapping the reset button (
gridState.filters.resetFilters()) does reset the filters, but the "no profiles found component" remains. The user has to set a new filter or pull to refresh to see profiles in the grid again.@ -20,0 +30,4 @@container={feedContainer}updating={rightNowState.refreshing}position="top"onrefresh={() => void rightNowState.refresh()}refresh()is destructive,{#if !loading}unmounts the control mid-gesture, andupdatingnever goes true because onlyreload()setsrefreshing— andreload()has no callers@ -0,0 +13,4 @@});beforeNavigate(() => {rightNowState.scrollY = window.scrollY;.pull-scrollerisoverflow-auto, sowindow.scrollYis always 0 andbeforeNavigateresets the saved position@ -0,0 +48,4 @@<div class="flex flex-1 justify-start"></div><Drawer.Title>Hosting Status</Drawer.Title><div class="flex flex-1 justify-end"><Switch id="hosting-filter-enabled" bind:checked={enabled} />Use
aria-labels or<label for>for those ids. Cover ine2e/accessible-names.spec.ts.Superseded by !520 !523 !544
Pull request closed