Add album share expiration choices #434

Open
Enucatl wants to merge 1 commit from Enucatl/open-grind:feat/album-share-expiration into main
Contributor

Offer the existing expiration options in the chat album composer and
remember the selected value.

Add the album sharing messages to the demo so that it can be tested.

Known UX behavior: re-enabling access in Shared with uses the last
expiration selected in chat. That dialog does not display expiration,
so restoring access can silently create a view-once share.

Fix #433.

Offer the existing expiration options in the chat album composer and remember the selected value. Add the album sharing messages to the demo so that it can be tested. Known UX behavior: re-enabling access in Shared with uses the last expiration selected in chat. That dialog does not display expiration, so restoring access can silently create a view-once share. Fix #433.
Add album share expiration choices
Some checks failed
check / check (pull_request) Has been cancelled
credits / credits (pull_request) Has been cancelled
cff1511497
Offer the existing expiration options in the chat album composer and
remember the selected value. Keep local selection state so a failed
preference save does not discard the choice. Let shareAlbum own the
default expiration instead of repeating it in AlbumShareActions.

Emit and retain demo album-share messages so the demo reflects sharing
behavior. Move conversation fixtures into a data file to meet lint limits.

Known UX behavior: re-enabling access in Shared with uses the last
expiration selected in chat. That dialog does not display expiration,
so restoring access can silently create a view-once share. Leave the
display unchanged for now.

Validation: type checking, lint and formatting passed; 62 focused unit
tests and 7 composer album browser tests passed.
Owner

As far as I know expirable album shares are paid-tier Grindr feature which can't be bypassed with the Honduras/Nigeria bypass. So if that's the case XTRA-gated features are currently not prioritized and must have an explanation of why sharing fails. If you could confirm whether the bypass works, please comment in this thread. Thank you.

As far as I know expirable album shares are paid-tier Grindr feature which can't be bypassed with the Honduras/Nigeria bypass. So if that's the case XTRA-gated features are currently not prioritized and must have an explanation of why sharing fails. If you could confirm whether the bypass works, please comment in this thread. Thank you.
Author
Contributor

I tried creating a new account without Xtra... it moved my extra to it and deactivated it on my real account:/

any tips on testing this?

I tried creating a new account without Xtra... it moved my extra to it and deactivated it on my real account:/ any tips on testing this?
Enucatl force-pushed feat/album-share-expiration from cff1511497
Some checks failed
check / check (pull_request) Has been cancelled
credits / credits (pull_request) Has been cancelled
to 78e4fee2e2
All checks were successful
credits / credits (pull_request) Successful in 1m28s
ci-orchestrator / provision running on cpx42 in fsn1
audit / audit (pull_request) Successful in 10s
check / check (pull_request) Successful in 52m55s
2026-10-08 22:06:59 +02:00
Compare
Owner

Closes #458

Closes #458
Owner

Confirmed non-bypassible

Confirmed non-bypassible
All checks were successful
credits / credits (pull_request) Successful in 1m28s
ci-orchestrator / provision running on cpx42 in fsn1
audit / audit (pull_request) Successful in 10s
check / check (pull_request) Successful in 52m55s
This pull request has changes conflicting with the target branch.
  • src/lib/app-data/preferences.svelte.ts
  • src/lib/demo/albums.test.ts
  • src/lib/demo/mock/conversation-seeds.ts
  • src/lib/demo/mock/conversations.ts
  • src/lib/ws.svelte.ts
  • src/routes/(protected)/(navbar)/settings/(subpage)/albums/album-editor/shared-with-state.svelte.test.ts
  • src/routes/(protected)/(navbar)/settings/(subpage)/albums/album-editor/shared-with-state.svelte.ts
  • src/routes/(protected)/chat/[conversationId]/message-composer/attachments/albums/ComposerAlbumsTab.svelte
  • src/routes/(protected)/chat/[conversationId]/message-composer/attachments/albums/ComposerAlbumsTab.svelte.test.ts
  • src/routes/(protected)/chat/[conversationId]/message-composer/attachments/albums/album-share-actions.svelte.ts
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'feat/album-share-expiration:Enucatl-feat/album-share-expiration'
git switch 'Enucatl-feat/album-share-expiration'
Sign in to join this conversation.
No description provided.