open-grind/open-grind
open-grind/open-grind
Watch
32
59
Fork
You've already forked open-grind
 32
Code Issues 102 Pull requests 9 Projects 1 Releases 8 Activity Actions

feat: add realtime websocket core #61

Closed
sealad886 wants to merge 6 commits from sealad886/realtime-core into main AGit
pull from: sealad886/realtime-core
merge into: open-grind:main
Conversation 4 Commits 6 Files changed 15 +1021 -610
sealad886 commented 2026-05-11 07:03:05 +02:00
Contributor
Copy link

Summary

  • add a shared realtime/WebSocket core with injected transport, async token provider, connection state, and typed event parsing
  • support Grindr-style command refs, token-bearing command payloads, response matching, command timeouts, and pending-command rejection on disconnect
  • add subscription dispatch for notification events and tests for close/token races

Stack

Depends on #59 and #60.

Validation

  • bun run test
  • bun run build
  • git diff --check

Note: bun run check still reports existing origin/main Svelte type errors in NavBar.svelte and ImageCarousel.svelte; this PR does not change those files.

## Summary - add a shared realtime/WebSocket core with injected transport, async token provider, connection state, and typed event parsing - support Grindr-style command refs, token-bearing command payloads, response matching, command timeouts, and pending-command rejection on disconnect - add subscription dispatch for notification events and tests for close/token races ## Stack Depends on #59 and #60. ## Validation - `bun run test` - `bun run build` - `git diff --check` Note: `bun run check` still reports existing `origin/main` Svelte type errors in `NavBar.svelte` and `ImageCarousel.svelte`; this PR does not change those files.
hloth commented 2026-05-11 11:36:25 +02:00
Owner
Copy link

Pending changes in #59 and #60 before reviewing

Pending changes in #59 and #60 before reviewing
sealad886 commented 2026-05-11 20:50:04 +02:00
Author
Contributor
Copy link

Base blockers are updated now: #59 was addressed in 11feccb, and #60 was addressed in 85ba445. Ready for review.

Base blockers are updated now: #59 was addressed in `11feccb`, and #60 was addressed in `85ba445`. Ready for review.
sealad886 force-pushed sealad886/realtime-core from e04fc0e0cf to 1c8284f200 2026-05-12 23:11:41 +02:00 Compare
sealad886 force-pushed sealad886/realtime-core from 1c8284f200 to 1bfa30f9be 2026-05-13 00:10:09 +02:00 Compare
sealad886 commented 2026-05-13 00:12:08 +02:00
Author
Contributor
Copy link

Updated stack after the pending base/review comments. Rebased onto current origin/main, replayed over #60 fixes (AppCache profile cache storage, Tauri 2.11 Rust/JS alignment), and force-pushed the refreshed AGit ref. This PR now has clean git merge-tree against origin/main and passes: git diff --check, bun run test:unit, bun run test:rust, bun run build. Ready for review.

Updated stack after the pending base/review comments. Rebased onto current `origin/main`, replayed over #60 fixes (AppCache profile cache storage, Tauri 2.11 Rust/JS alignment), and force-pushed the refreshed AGit ref. This PR now has clean `git merge-tree` against `origin/main` and passes: `git diff --check`, `bun run test:unit`, `bun run test:rust`, `bun run build`. Ready for review.
hloth commented 2026-07-19 21:47:49 +02:00
Owner
Copy link

Superceded, websocket now lives in the grindr crate, though ref-correlation is a valid future issue.

Superceded, websocket now lives in the grindr crate, though ref-correlation is a valid future issue.
hloth closed this pull request 2026-07-19 21:47:50 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
app

   
bug
Something is not working

  
client side exclusive

   
🗳️ community vote
Community feedback needed to justify change

  
⚠️ critical

   
discussion
This is a discussion or a question

  
docs

   
duplicate
This issue or pull request already exists

  
emulator
Reproduce in an emulator

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
not open grind
Another client or fork

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
app
bug
client side exclusive
🗳️ community vote
⚠️ critical
discussion
docs
duplicate
emulator
enhancement
help wanted
invalid
not open grind
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
open-grind/open-grind!61
No description provided.